Conversation
dmadisetti
left a comment
dmadisetti
left a comment
There was a problem hiding this comment.
Dope! Super excited for this. Can't wait to see it on the store. Code looks great, seems like it took a lot of tweaking to get just right. Appreciate you for that. I left comments like I would for any bigger project. The only other thing I'd do is sync gameframe with the nom project
| node.id = "container"; // Append the text to <li> | ||
| document.body.appendChild(node); // Append <li> to <ul> with id="myList" | ||
|
|
||
| document.querySelector("#container").innerHTML = window.atob(`{{{html}}}`); |
There was a problem hiding this comment.
I would set innerHTML prior to appending to page
| document.body.style.backgroundColor = "black"; | ||
|
|
||
| document.querySelector("#container").innerHTML = window.atob(`{{{html}}}`); | ||
| var node = document.createElement("DIV"); // Create a <li> node |
There was a problem hiding this comment.
Clean up comments + make DIV -> div
|
|
||
|
|
||
| Check out the [CarolinaIgnites coding editor ](https://editor.carolinaignites.org) to create and player your own games. | ||
|
|
There was a problem hiding this comment.
Hmm haven't tested, but you might have to make these links [text](link)
| _refresh(widget.game); | ||
| double width = MediaQuery.of(context).size.width; | ||
| double adjustment = (width > VIEW_SIZE) ? (width - VIEW_SIZE) / 2 : 0; | ||
|
|
There was a problem hiding this comment.
I'd just run a flutter format to clean up some of these
| double width = MediaQuery.of(context).size.width; | ||
| double adjustment = (width > VIEW_SIZE) ? (width - VIEW_SIZE) / 2 : 0; | ||
|
|
||
| if (width > 1000) { |
There was a problem hiding this comment.
Hmm! Even more adjusted? Make me wonder what this page looks like on iPad. Would move this magic number to constants.dart, and maybe use a known break point number:
http://devfacts.com/media-queries-breakpoints-2020/
Looks like 992, 1024 (for iPads) or 1200
|
|
||
| login() async { | ||
| _signedIn = (await GamesServices.signIn()) == "success"; | ||
| print(_signedIn); |
There was a problem hiding this comment.
I'd clean up some prints, and leave what's remaining as verbose and as debugPrints
| if (caller == "QR" && _signedIn) { | ||
| analytics.logUnlockAchievement(id: QR_ACHIEVEMENT); | ||
| GamesServices.unlock(achievement: Achievement(androidID: QR_ACHIEVEMENT)); | ||
| GamesServices.unlock(achievement: Achievement(androidID: QR_ACHIEVEMENT, iOSID: QR_ACHIEVEMENT)); |
There was a problem hiding this comment.
Does this works? If it doesn't break things then cool
| @override | ||
| Widget build(BuildContext context) { | ||
| var devicePhysicalPixelWidth = MediaQuery.of(context).size.width * MediaQuery.of(context).devicePixelRatio; | ||
| var headerPadding = (devicePhysicalPixelWidth > 1000) ? MediaQuery.of(context).size.width * 0.15 : 64; |
There was a problem hiding this comment.
I'd move some of these magic numbers to constants.dart with nice variable names. Linda hard for me to fully image this
2 participants
No description provided.